Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: copy database from #3164

Merged
merged 10 commits into from Jan 22, 2024
Merged

feat: copy database from #3164

merged 10 commits into from Jan 22, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Jan 15, 2024 •
edited

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR adds support for COPY DATABASE FROM statement that can be conveviently used for restoring backup data exported by COPY DATABASE TO statement.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3159

@github-actions github-actions bot added Doc update required This change requires document update on https://github.com/GreptimeTeam/docs Size: L labels Jan 15, 2024
@sunng87 sunng87 mentioned this pull request Jan 15, 2024
Closed
@v0y4g3r v0y4g3r added Documentation Improvements or additions to documentation Enhancement New feature or request labels Jan 15, 2024
fengjiachun
fengjiachun approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/operator/src/statement/copy_database.rs Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2024 •
edited

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (e5a8831) 85.84% compared to head (132407f) 85.38%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3164      +/-   ##
==========================================
- Coverage   85.84%   85.38%   -0.47%     
==========================================
  Files         840      840              
  Lines      137539   137633      +94     
==========================================
- Hits       118076   117513     -563     
- Misses      19463    20120     +657

@v0y4g3r v0y4g3r requested a review from evenyag January 22, 2024 06:19
killme2008
killme2008 approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Jan 22, 2024
Merged via the queue into GreptimeTeam:main with commit 3834ea7 Jan 22, 2024
15 checks passed
@v0y4g3r v0y4g3r deleted the feat/copy-database-from branch January 22, 2024 06:51
@v0y4g3r v0y4g3r mentioned this pull request Jan 22, 2024
Closed
@evenyag evenyag mentioned this pull request Feb 5, 2024
Merged
3 tasks
@evenyag evenyag mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@WenyXu WenyXu Awaiting requested review from WenyXu

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield

@evenyag evenyag Awaiting requested review from evenyag

Assignees
No one assigned
Labels
Doc update required This change requires document update on https://github.com/GreptimeTeam/docs Documentation Improvements or additions to documentation Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@v0y4g3r @killme2008 @MichaelScofield @fengjiachun @evenyag