Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds date_format function #3167

Merged
merged 6 commits into from Jan 17, 2024
Merged

feat: adds date_format function #3167

merged 6 commits into from Jan 17, 2024

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Jan 15, 2024 •
edited

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Main changes:

  • Adds date_format function to format timestamp/date/datetime by the given format.
  • todo:
    • aware of timezone setting

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Close #3139

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: L labels Jan 15, 2024
@killme2008 killme2008 marked this pull request as ready for review January 15, 2024 11:35
@github-actions github-actions bot added docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Jan 15, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (1294d6f) 85.54% compared to head (bd39792) 85.12%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3167      +/-   ##
==========================================
- Coverage   85.54%   85.12%   -0.42%     
==========================================
  Files         829      830       +1     
  Lines      135711   136146     +435     
==========================================
- Hits       116096   115901     -195     
- Misses      19615    20245     +630

waynexia
waynexia approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/common/time/src/timestamp.rs Show resolved Hide resolved
@killme2008 killme2008 added this pull request to the merge queue Jan 17, 2024
Merged via the queue into GreptimeTeam:main with commit 204b943 Jan 17, 2024
19 checks passed
@killme2008 killme2008 deleted the feature/date-format-function branch January 17, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunng87 sunng87 sunng87 approved these changes

@waynexia waynexia waynexia approved these changes

@Taylor-lagrange Taylor-lagrange Awaiting requested review from Taylor-lagrange

@QuenKar QuenKar Awaiting requested review from QuenKar

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
docs-required This change requires docs update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: date_format(datetime, format) to format a timestamp/date/datetime value
3 participants
@killme2008 @sunng87 @waynexia