Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Arrow IPC output format for http rest api #3177

Merged
merged 6 commits into from Jan 24, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Jan 16, 2024

I hereby agree to the terms of the GreptimeDB CLA

This patch is initial work to add arrow output format for our http sql api. By using arrow output format it is possible to do zero-copy with arrowjs ecosystem, including visualization library vega (with vega-arrow-loader) and many more.

I will be seeking to add streaming support for output types like csv and arrow in future patch.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added Invalid PR Title docs-not-required This change does not impact docs. labels Jan 16, 2024
@sunng87 sunng87 changed the title feature: add Arrow IPC output format for http rest api feat: add Arrow IPC output format for http rest api Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (816d948) 85.39% compared to head (36bf1e6) 85.30%.
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3177      +/-   ##
==========================================
- Coverage   85.39%   85.30%   -0.10%     
==========================================
  Files         827      841      +14     
  Lines      135264   137641    +2377     
==========================================
+ Hits       115509   117411    +1902     
- Misses      19755    20230     +475     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Jan 24, 2024
Merged via the queue into GreptimeTeam:main with commit 1711ad4 Jan 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants