feat: tables stream with CatalogManager #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3180 +/- ##
==========================================
- Coverage 85.63% 85.16% -0.48%
==========================================
Files 829 829
Lines 135773 135837 +64
==========================================
- Hits 116273 115682 -591
- Misses 19500 20155 +655 |
fengjiachun
force-pushed
the
feat/tables-stream
branch
from
b87bb80
to
9f86d6a
Compare
WenyXu
reviewed
Jan 16, 2024
Co-authored-by: Weny Xu <wenymedia@gmail.com>
Co-authored-by: Weny Xu <wenymedia@gmail.com>
Co-authored-by: Weny Xu <wenymedia@gmail.com>
Co-authored-by: Weny Xu <wenymedia@gmail.com>
fengjiachun
force-pushed
the
feat/tables-stream
branch
from
1a1c8ec
to
7b095e5
Compare
WenyXu
approved these changes
Jan 16, 2024
|
Some code has been modified (MemoryCatalogManager). PTALA @WenyXu |
MichaelScofield
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
CatalogManager: get tables with stream by catalog and schemaChecklist
Refer to a related PR or issue link (optional)