Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change back GREPTIME_DB_HEADER_NAME header key name #3184

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly changes back GREPTIME_DB_HEADER_NAME to its previous key name.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. size/xs labels Jan 17, 2024
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/servers/src/http/header.rs Show resolved Hide resolved
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbd0197) 85.74% compared to head (91115f9) 85.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3184      +/-   ##
==========================================
- Coverage   85.74%   85.32%   -0.43%     
==========================================
  Files         828      828              
  Lines      136027   136027              
==========================================
- Hits       116641   116068     -573     
- Misses      19386    19959     +573     

@sunng87 sunng87 added this pull request to the merge queue Jan 17, 2024
Merged via the queue into GreptimeTeam:main with commit ae160c2 Jan 17, 2024
16 checks passed
@shuiyisong shuiyisong deleted the fix/db_name branch January 22, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants