Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(index): S3 EntityTooSmall error #3192

Merged

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Jan 18, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Set the buffer size for the OpenDAL writer to avoid uploading small parts.

Additionally, ensure that index-related exceptions cause panic in test scenarios.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc requested review from killme2008 and fengjiachun and removed request for killme2008 January 18, 2024 07:47
@github-actions github-actions bot added the docs-required This change requires docs update. label Jan 18, 2024
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (6320590) 85.81% compared to head (12ad0b6) 85.32%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3192      +/-   ##
==========================================
- Coverage   85.81%   85.32%   -0.49%     
==========================================
  Files         832      833       +1     
  Lines      136308   136802     +494     
==========================================
- Hits       116967   116726     -241     
- Misses      19341    20076     +735     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongzc
Copy link
Contributor Author

zhongzc commented Jan 19, 2024

@evenyag @WenyXu PTAL

@shuiyisong shuiyisong added this pull request to the merge queue Jan 19, 2024
Merged via the queue into GreptimeTeam:main with commit 2e4c48a Jan 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants