Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds parse options for SQL parser #3193

Merged
merged 6 commits into from Jan 19, 2024

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Jan 18, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Prepare for the following PRs and #3175, main changes:

  • Added ParseOptions to SQL ParserContext.
  • Let all the parsing sql places be aware of ParseOptions.
  • Improve ensure_value_lists_strictly_increased in creating table parser, checking column types to avoid timezone errors.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2907

@killme2008 killme2008 marked this pull request as ready for review January 18, 2024 09:06
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (3d7d2fd) 85.79% compared to head (3dcfb4d) 85.39%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3193      +/-   ##
==========================================
- Coverage   85.79%   85.39%   -0.40%     
==========================================
  Files         829      833       +4     
  Lines      136285   137109     +824     
==========================================
+ Hits       116926   117089     +163     
- Misses      19359    20020     +661     

@killme2008 killme2008 changed the title feat: adds parse options for parser and timezone to scan request feat: adds parse options for SQL parser Jan 18, 2024
@killme2008
Copy link
Contributor Author

Removed the timezone from ScanRequest. PTAL @v0y4g3r @waynexia

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/query/src/parser.rs Outdated Show resolved Hide resolved
killme2008 and others added 2 commits January 19, 2024 16:51
Co-authored-by: Yingwen <realevenyag@gmail.com>
@v0y4g3r v0y4g3r added this pull request to the merge queue Jan 19, 2024
Merged via the queue into GreptimeTeam:main with commit 5e89472 Jan 19, 2024
15 checks passed
@killme2008 killme2008 deleted the feature/timezone-context branch March 4, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants