New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds parse options for SQL parser #3193
Merged
v0y4g3r
merged 6 commits into
GreptimeTeam:main
from
killme2008:feature/timezone-context
Jan 19, 2024
Merged
feat: adds parse options for SQL parser #3193
v0y4g3r
merged 6 commits into
GreptimeTeam:main
from
killme2008:feature/timezone-context
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3193 +/- ##
==========================================
- Coverage 85.79% 85.39% -0.40%
==========================================
Files 829 833 +4
Lines 136285 137109 +824
==========================================
+ Hits 116926 117089 +163
- Misses 19359 20020 +661 |
3 tasks
v0y4g3r
reviewed
Jan 18, 2024
killme2008
changed the title
feat: adds parse options for parser and timezone to scan request
feat: adds parse options for SQL parser
Jan 18, 2024
v0y4g3r
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
evenyag
approved these changes
Jan 19, 2024
Co-authored-by: Yingwen <realevenyag@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Prepare for the following PRs and #3175, main changes:
ParseOptions
to SQLParserContext
.ParseOptions
.ensure_value_lists_strictly_increased
in creating table parser, checking column types to avoid timezone errors.Checklist
Refer to a related PR or issue link (optional)
#2907