Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pg create alter table expr translator #3206

Merged
merged 4 commits into from Jan 25, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 20, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Add alter table expr translator
  2. Add create table expr translator

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3174

waits for #3203

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: XL labels Jan 20, 2024
@github-actions github-actions bot added Size: M and removed Size: XL labels Jan 23, 2024
@WenyXu WenyXu marked this pull request as ready for review January 23, 2024 03:15
@zhongzc
Copy link
Contributor

zhongzc commented Jan 23, 2024

There is a translator called greptime. Is it the mysql protocol?

@WenyXu
Copy link
Member Author

WenyXu commented Jan 23, 2024

There is a translator called greptime. Is it the mysql protocol?

I guess it is called a dialect more precisely, instead of a protocol. No matter what we use which protocol in greptime, it always supports the show create table, and desc table statements.

@zhongzc
Copy link
Contributor

zhongzc commented Jan 23, 2024

I guess it is called a dialect more precisely, instead of a protocol. No matter what we use which protocol in greptime, it always supports the show create table, and desc table statements.

I noticed that the translator mod has two submods, one is greptime and the other is postgres. Many of their codes are similar, so I am curious whether there is a dialect of greptime or just MySQL.

@WenyXu
Copy link
Member Author

WenyXu commented Jan 23, 2024

I noticed that the translator mod has two submods, one is greptime and the other is postgres. Many of their codes are similar, so I am curious whether there is a dialect of greptime or just MySQL.

Good point. I renamed the greptime to mysql.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (364754a) 85.85% compared to head (ec0ed3c) 85.38%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3206      +/-   ##
==========================================
- Coverage   85.85%   85.38%   -0.48%     
==========================================
  Files         844      847       +3     
  Lines      138609   138767     +158     
==========================================
- Hits       119009   118489     -520     
- Misses      19600    20278     +678     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Jan 25, 2024
Merged via the queue into GreptimeTeam:main with commit 673a4bd Jan 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants