Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove __name__ matcher from processed matcher list #3213

Merged
merged 1 commit into from Jan 22, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fix the bug reported by @dekelpilli in #1042 (comment)

The __name__ matcher is not removed after special preprocess logic, resulting in the afterword plan phase treating it as a column name.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 22, 2024
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (278e4c8) 85.79% compared to head (7dfb5a6) 85.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3213      +/-   ##
==========================================
- Coverage   85.79%   85.34%   -0.45%     
==========================================
  Files         840      840              
  Lines      137698   137698              
==========================================
- Hits       118136   117521     -615     
- Misses      19562    20177     +615     

@waynexia waynexia added this pull request to the merge queue Jan 22, 2024
Merged via the queue into GreptimeTeam:main with commit 8cc7129 Jan 22, 2024
17 checks passed
@waynexia waynexia deleted the fix-name-matcher branch January 22, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants