Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix MockInstance rebuild issue #3218

Merged
merged 2 commits into from Jan 24, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 23, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Reuse the GreptimeStandalone KvBackendRef during the rebuilding.
The reason why I didn't rebuild the instance after dropping the KvBackendRef (and keep TestGuard), based on my experience, it's a little tricky, the FileLock used in the KvBackendRef seems not to release as soon as the KvBackendRef is dropped (maybe somewhere, still keep the KvBackendRef as well).

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3202

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Jan 23, 2024
@WenyXu WenyXu marked this pull request as draft January 23, 2024 04:47
@WenyXu WenyXu marked this pull request as ready for review January 23, 2024 05:08
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d75cf86) 85.85% compared to head (f5a0c1b) 85.35%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3218      +/-   ##
==========================================
- Coverage   85.85%   85.35%   -0.50%     
==========================================
  Files         844      845       +1     
  Lines      138656   138805     +149     
==========================================
- Hits       119042   118478     -564     
- Misses      19614    20327     +713     

tests-integration/src/cluster.rs Outdated Show resolved Hide resolved
tests-integration/src/cluster.rs Outdated Show resolved Hide resolved
@niebayes niebayes added this pull request to the merge queue Jan 24, 2024
Merged via the queue into GreptimeTeam:main with commit f82ddc9 Jan 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants