Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change Range Query’s default align behavior aware of timezone #3219

Merged
merged 2 commits into from Jan 24, 2024

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Jan 23, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Changed Range Query’s default align behavior to 1970-01-01 00:00:00 aware of the timezone.

cc @nicecui

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2907

@killme2008 killme2008 marked this pull request as ready for review January 23, 2024 05:24
@github-actions github-actions bot added Size: M docs-required This change requires docs update. labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31787f4) 85.90% compared to head (1742732) 85.42%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3219      +/-   ##
==========================================
- Coverage   85.90%   85.42%   -0.49%     
==========================================
  Files         840      844       +4     
  Lines      138162   138666     +504     
==========================================
- Hits       118691   118456     -235     
- Misses      19471    20210     +739     

@waynexia waynexia added this pull request to the merge queue Jan 24, 2024
Merged via the queue into GreptimeTeam:main with commit 7323e9b Jan 24, 2024
18 checks passed
@killme2008 killme2008 deleted the feature/range-query-align branch January 24, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants