Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read column and region info from state cache #3222

Merged
merged 1 commit into from Jan 23, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Jan 23, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Closes #3220

Change the metadata retrieving behavior from read underlying mito to memory state cache. This can alleviate the high CPU usage a lot.

CPU curve afterward:
image

(There are three flush in this graph)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Closes #3220

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 23, 2024
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Jan 23, 2024
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into GreptimeTeam:main with commit 8485c9a Jan 23, 2024
19 checks passed
@waynexia waynexia deleted the state-cache branch January 23, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High memory and CPU usage under metric engine
4 participants