Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only register region keeper while creating physical table #3223

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 23, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Only register region keeper while creating physical table

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19413eb) 85.86% compared to head (66ad2a5) 85.41%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
- Coverage   85.86%   85.41%   -0.45%     
==========================================
  Files         844      844              
  Lines      138618   138635      +17     
==========================================
- Hits       119023   118416     -607     
- Misses      19595    20219     +624     

@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 23, 2024
Merged via the queue into GreptimeTeam:main with commit d75cf86 Jan 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants