Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix create table ddl return incorrect table id #3232

Merged
merged 2 commits into from Jan 25, 2024
Merged

fix: fix create table ddl return incorrect table id #3232

merged 2 commits into from Jan 25, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 24, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix create table ddl return incorrect table id

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

fix #3200

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 24, 2024
@WenyXu WenyXu marked this pull request as draft January 24, 2024 14:34
@WenyXu WenyXu marked this pull request as ready for review January 24, 2024 14:48
fengjiachun
fengjiachun approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun mentioned this pull request Jan 25, 2024
Closed
@waynexia waynexia added this pull request to the merge queue Jan 25, 2024
Merged via the queue into GreptimeTeam:main with commit 8bade8f Jan 25, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@waynexia waynexia waynexia approved these changes

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield MichaelScofield is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create table procedure returns the incorrect table id
3 participants
@WenyXu @fengjiachun @waynexia