Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: http sql api return schema on empty resultset #3237

Merged

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Jan 25, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Previously we don't return schema for empty resultset. This patch corrected this for better usability.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Jan 25, 2024
@sunng87 sunng87 changed the title feat: return schema on empty resultset feat: http sql api return schema on empty resultset Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (814924f) 85.81% compared to head (80e5b1a) 85.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
- Coverage   85.81%   85.37%   -0.45%     
==========================================
  Files         845      845              
  Lines      138853   138876      +23     
==========================================
- Hits       119158   118561     -597     
- Misses      19695    20315     +620     

@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 25, 2024
Merged via the queue into GreptimeTeam:main with commit 1bc4f25 Jan 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants