feat: return request outdated error on handling alter #3239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-not-required
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
waynexia
force-pushed
the
alter-return-error
branch
from
77cee7f
to
1be645f
Compare
fengjiachun
approved these changes
Jan 25, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3239 +/- ##
==========================================
- Coverage 85.82% 85.17% -0.65%
==========================================
Files 845 856 +11
Lines 138876 140105 +1229
==========================================
+ Hits 119184 119334 +150
- Misses 19692 20771 +1079 |
evenyag
reviewed
Jan 25, 2024
WenyXu
reviewed
Jan 25, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
evenyag
reviewed
Jan 25, 2024
evenyag
approved these changes
Jan 25, 2024
Co-authored-by: Weny Xu <wenymedia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Mito engine returns ok on outdated requests. It confuses the caller to know if the request is actually performed. This PR changes the behavior on outdated alter request. It will now return a new status code
RequestOutdatedinstead of an incorrect success.Checklist
Refer to a related PR or issue link (optional)