Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: align chrono and some forked test deps to upstream #3245

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Jan 26, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fixes #3228

This patch updates tests of our time module to adopt changes from upstream chrono on min/max year.

It also changes some forked dependencies to upstream.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 26, 2024
@sunng87 sunng87 requested a review from waynexia January 26, 2024 06:13
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5617b28) 85.62% compared to head (3e14cbb) 85.17%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3245      +/-   ##
==========================================
- Coverage   85.62%   85.17%   -0.45%     
==========================================
  Files         856      856              
  Lines      140105   140098       -7     
==========================================
- Hits       119963   119334     -629     
- Misses      20142    20764     +622     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunng87 sunng87 added this pull request to the merge queue Jan 26, 2024
Merged via the queue into GreptimeTeam:main with commit 14b233c Jan 26, 2024
15 checks passed
@sunng87 sunng87 deleted the test/update-chrono branch January 26, 2024 07:55
shuiyisong pushed a commit to shuiyisong/greptimedb that referenced this pull request Jan 30, 2024
…m#3245)

* test: update chrono and its tests

* chore: switch some deps to upstream version

* test: update timestamp range in sqlness tests
shuiyisong pushed a commit to shuiyisong/greptimedb that referenced this pull request Jan 30, 2024
…m#3245)

* test: update chrono and its tests

* chore: switch some deps to upstream version

* test: update timestamp range in sqlness tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failed when upgrading to chrono 0.4.32
3 participants