Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create tables in batch on prom write #3246

Merged
merged 3 commits into from Jan 26, 2024
Merged

feat: create tables in batch on prom write #3246

merged 3 commits into from Jan 26, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Batch create tables on prometheus wtrite

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 26, 2024
waynexia
waynexia approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added Size: M and removed Size: S labels Jan 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (f99b087) 85.63% compared to head (6cbc3a3) 85.36%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3246      +/-   ##
==========================================
- Coverage   85.63%   85.36%   -0.27%     
==========================================
  Files         856      856              
  Lines      140079   140170      +91     
==========================================
- Hits       119950   119659     -291     
- Misses      20129    20511     +382

@fengjiachun fengjiachun added this pull request to the merge queue Jan 26, 2024
Merged via the queue into GreptimeTeam:main with commit 3201aea Jan 26, 2024
15 checks passed
@fengjiachun fengjiachun deleted the feat/create-tables-on-prom-write branch January 26, 2024 12:59
shuiyisong pushed a commit to shuiyisong/greptimedb that referenced this pull request Jan 30, 2024
@fengjiachun @shuiyisong
feat: create tables in batch on prom write (GreptimeTeam#3246)
d7fadd9 
* feat: create tables in batch on prom write

* feat: add logic table ids to log

* fix: miss tabble ids in response
shuiyisong pushed a commit to shuiyisong/greptimedb that referenced this pull request Jan 30, 2024
@fengjiachun @shuiyisong
feat: create tables in batch on prom write (GreptimeTeam#3246)
912ae5a 
* feat: create tables in batch on prom write

* feat: add logic table ids to log

* fix: miss tabble ids in response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@zhongzc zhongzc zhongzc approved these changes

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield MichaelScofield is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fengjiachun @waynexia @zhongzc