Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make binary name a Dockerfile "ARG" #3254

Merged
merged 2 commits into from
Jan 29, 2024
Merged

build: make binary name a Dockerfile "ARG" #3254

merged 2 commits into from
Jan 29, 2024

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

For building other projects.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. size/xs labels Jan 29, 2024
zyy17
zyy17 reviewed Jan 29, 2024
View reviewed changes
docker/ci/ubuntu/Dockerfile Outdated Show resolved Hide resolved
zyy17
zyy17 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fengjiachun
fengjiachun approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Jan 29, 2024
Merged via the queue into GreptimeTeam:main with commit fc25b7c Jan 29, 2024
11 checks passed
@MichaelScofield MichaelScofield deleted the ci/pass-target-bin branch January 29, 2024 08:14
@daviderli614 daviderli614 mentioned this pull request Feb 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyy17 zyy17 zyy17 approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelScofield @zyy17 @fengjiachun