Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cli export database default value #3259

Merged
merged 1 commit into from Jan 30, 2024

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This closes #3250.

This should be too trivial to test.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Signed-off-by: tison <wander4096@gmail.com>
@github-actions github-actions bot added size/xs docs-not-required This change does not impact docs. labels Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5a2b04) 85.78% compared to head (f17d785) 85.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3259      +/-   ##
==========================================
- Coverage   85.78%   85.37%   -0.41%     
==========================================
  Files         856      856              
  Lines      140188   140188              
==========================================
- Hits       120261   119689     -572     
- Misses      19927    20499     +572     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Jan 30, 2024
Merged via the queue into GreptimeTeam:main with commit 60e760b Jan 30, 2024
15 checks passed
@tisonkun tisonkun deleted the fixup-default-value branch May 3, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default config value of tool cli export is wrong
3 participants