Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Copy From): fix incorrect type casts #3264

Merged
merged 4 commits into from Jan 30, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 29, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Introduce the RecordBatchStreamTypeAdapter
  2. Fix incorrect type casts

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

fix #3260

@github-actions github-actions bot added Size: M docs-not-required This change does not impact docs. labels Jan 29, 2024
@WenyXu WenyXu force-pushed the fix/incorrect-type-casts branch 2 times, most recently from f656dd9 to 63d0c26 Compare January 29, 2024 15:34
@WenyXu
Copy link
Member Author

WenyXu commented Jan 30, 2024

I will add more tests for the Copy From in another PR later.

@fengjiachun fengjiachun added this pull request to the merge queue Jan 30, 2024
Merged via the queue into GreptimeTeam:main with commit ddbd0ab Jan 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to copy from this csv file
3 participants