Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SQL insertion and column default constraint aware of timezone #3266

Merged
merged 7 commits into from Jan 30, 2024

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Jan 30, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

真 の Final Piece of #2907 :

  • SQL insertion with date/datetime/timestamp literals should respect the session timezone while parsing.
  • Create table or alter table that contains column default constraint value aware of session timezone.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2907

@github-actions github-actions bot added docs-not-required This change does not impact docs. Invalid PR Title labels Jan 30, 2024
@killme2008 killme2008 changed the title Fix/sql value timezone fix: sql insertion and column default constrait aware of timezone Jan 30, 2024
@killme2008 killme2008 changed the title fix: sql insertion and column default constrait aware of timezone fix: SQL insertion and column default constrait aware of timezone Jan 30, 2024
@killme2008 killme2008 changed the title fix: SQL insertion and column default constrait aware of timezone fix: SQL insertion and column default constraint aware of timezone Jan 30, 2024
@killme2008 killme2008 marked this pull request as ready for review January 30, 2024 08:03
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e5a2b04) 85.78% compared to head (9e22208) 85.36%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3266      +/-   ##
==========================================
- Coverage   85.78%   85.36%   -0.42%     
==========================================
  Files         856      856              
  Lines      140188   140457     +269     
==========================================
- Hits       120261   119908     -353     
- Misses      19927    20549     +622     

@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 30, 2024
Merged via the queue into GreptimeTeam:main with commit 43ef082 Jan 30, 2024
31 checks passed
@killme2008 killme2008 deleted the fix/sql-value-timezone branch January 30, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants