Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fraction part in timestamp #3272

Merged
merged 2 commits into from Feb 1, 2024
Merged

feat: support fraction part in timestamp #3272

merged 2 commits into from Feb 1, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Jan 31, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

allow parsing Timestampe wiht fraction part like 1970-01-01 00:00:00.042, which is supported in arrow's Array cast, so it make sense to maintance consistency

  • Summarize your change (mandatory)
    support decimal fraction part in DateTime::from_str , i.e. 1970-01-01 00:00:00.042

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e375060) 85.66% compared to head (424d4fa) 85.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3272   +/-   ##
=======================================
  Coverage   85.66%   85.66%           
=======================================
  Files         859      859           
  Lines      140780   140796   +16     
=======================================
+ Hits       120595   120609   +14     
- Misses      20185    20187    +2     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit e89f5dc Feb 1, 2024
20 checks passed
@fengjiachun fengjiachun deleted the ts_mill_secs branch February 1, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants