Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fe_opts after setup_frontend_plugins in standalone #3275

Merged
merged 2 commits into from Feb 2, 2024

Conversation

shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Use fe_opts processed by setup_frontend_plugins instead of original MixOptions::FrontendOptions

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@sunng87
Copy link
Member

sunng87 commented Feb 2, 2024

Is it possible to take ownership of opts in setup_frontend_plugins? so there is no chance to reuse opts afterwards.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e89f5dc) 85.63% compared to head (b779196) 85.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3275      +/-   ##
==========================================
- Coverage   85.63%   85.23%   -0.40%     
==========================================
  Files         859      859              
  Lines      140796   140796              
==========================================
- Hits       120564   120005     -559     
- Misses      20232    20791     +559     

@github-actions github-actions bot added Size: S and removed size/xs labels Feb 2, 2024
@shuiyisong
Copy link
Contributor Author

Is it possible to take ownership of opts in setup_frontend_plugins? so there is no chance to reuse opts afterwards.

we can move the ownership of FrontendOptions out of MixOptions so that opts.frontend is no longer usable

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Feb 2, 2024
Merged via the queue into GreptimeTeam:main with commit 6ab3a88 Feb 2, 2024
16 checks passed
@shuiyisong shuiyisong deleted the fix/standalone_startup branch February 2, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants