Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect StatusCode parsing #3281

Merged
merged 2 commits into from Feb 5, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Feb 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix incorrect StatusCode parsing

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

close #3279

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (902570a) 85.69% compared to head (69f63f9) 85.22%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3281      +/-   ##
==========================================
- Coverage   85.69%   85.22%   -0.48%     
==========================================
  Files         859      859              
  Lines      140796   140756      -40     
==========================================
- Hits       120662   119965     -697     
- Misses      20134    20791     +657     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM orz

src/common/error/src/status_code.rs Show resolved Hide resolved
@fengjiachun fengjiachun added this pull request to the merge queue Feb 5, 2024
Merged via the queue into GreptimeTeam:main with commit 770da02 Feb 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alter exits unexpected without retry
3 participants