feat: put all filter exprs in a filter plan separately #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
github-actions
bot
added
Size: S
docs-not-required
waynexia
commented
Feb 6, 2024
zhongzc
approved these changes
Feb 6, 2024
evenyag
approved these changes
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3288 +/- ##
==========================================
- Coverage 85.67% 85.21% -0.47%
==========================================
Files 865 865
Lines 141034 141035 +1
==========================================
- Hits 120836 120180 -656
- Misses 20198 20855 +657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The promql planner is used to construct a table scan plan with inlined filter. But it turns out that (1) not all filters are supported to be in table scan and (2) substrait encoder will discard those inlined filters. Thus this PR put all filters into a dedicated plan to make sure they are executed.
Checklist
Refer to a related PR or issue link (optional)