New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mito): adjust seg size of inverted index to finer granularity instead of row group level #3289
feat(mito): adjust seg size of inverted index to finer granularity instead of row group level #3289
Conversation
…stead of row group level Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
src/index/src/inverted_index/search/index_apply/predicates_apply.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3289 +/- ##
==========================================
- Coverage 85.67% 85.08% -0.60%
==========================================
Files 865 872 +7
Lines 141035 141688 +653
==========================================
- Hits 120838 120550 -288
- Misses 20197 21138 +941 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Adjusting the segment row count from 102400 (row group size) to 1024 helps provide a finer granularity of filtering than the row group level, which greatly enhances the filtering capability of the inverted index.
In the personal testing scenario, an improvement of over 5x was achieved.
Checklist
Refer to a related PR or issue link (optional)