feat: organize tracing on query path #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
waynexia
commented
Feb 18, 2024
zhongzc
reviewed
Feb 18, 2024
zhongzc
reviewed
Feb 18, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
zhongzc
reviewed
Feb 18, 2024
zhongzc
approved these changes
Feb 18, 2024
Co-authored-by: Zhenchi <zhongzc_arch@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
==========================================
- Coverage 85.54% 85.10% -0.44%
==========================================
Files 872 872
Lines 141967 141958 -9
==========================================
- Hits 121440 120820 -620
- Misses 20527 21138 +611 |
shuiyisong
approved these changes
Feb 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 18, 2024
* feat: organize tracing on query path Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * warp json conversion to TracingContext's methods Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * remove unnecessary .trace() Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * Update src/query/src/dist_plan/merge_scan.rs Co-authored-by: Zhenchi <zhongzc_arch@outlook.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com> Co-authored-by: Zhenchi <zhongzc_arch@outlook.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
A tempo example under standalone mode:
Two phases (before and after the merge scan) are associated to one trace id.
This PR uses
session_idinTaskContextto pass tracing-related metadata.Checklist
Refer to a related PR or issue link (optional)
Related to #1312