Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: batch get physical table routes #3319

Merged

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As the title said

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (29f11d7) 85.57% compared to head (64075df) 85.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3319      +/-   ##
==========================================
- Coverage   85.57%   85.07%   -0.51%     
==========================================
  Files         872      872              
  Lines      141958   142006      +48     
==========================================
- Hits       121481   120808     -673     
- Misses      20477    21198     +721     

@fengys1996 fengys1996 self-requested a review February 19, 2024 05:13
src/common/meta/src/key/table_route.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Feb 19, 2024
Merged via the queue into GreptimeTeam:main with commit aa569f7 Feb 19, 2024
16 checks passed
@fengjiachun fengjiachun deleted the feat/batch-get-physical-table-routes branch February 19, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants