Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric-engine): set index options for data region #3330

Merged

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Feb 19, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • ignore building index on column tsid to save space.
  • set seg row count to 256 to improve query performance of metric engine

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 19, 2024
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc force-pushed the zhongzc/metric-engine-index-options branch from ae53fe3 to e92ffdd Compare February 19, 2024 16:56
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43fd87e) 85.23% compared to head (e92ffdd) 84.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
- Coverage   85.23%   84.81%   -0.43%     
==========================================
  Files         878      879       +1     
  Lines      143009   143026      +17     
==========================================
- Hits       121896   121306     -590     
- Misses      21113    21720     +607     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/metric-engine/src/engine/options.rs Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Feb 20, 2024
Merged via the queue into GreptimeTeam:main with commit 6628c41 Feb 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants