feat: replace pk index with pk_weight during freeze #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
==========================================
- Coverage 85.28% 84.89% -0.39%
==========================================
Files 884 884
Lines 144256 144265 +9
==========================================
- Hits 123028 122480 -548
- Misses 21228 21785 +557 |
v0y4g3r
force-pushed
the
feat/merge-tree-data-buffer-freeze
branch
from
ac56c1f
to
01e6cb9
Compare
evenyag
approved these changes
Feb 21, 2024
38 tasks
MichaelScofield
pushed a commit
to MichaelScofield/greptimedb
that referenced
this pull request
Feb 21, 2024
* feat: replace pk index with pk_weight during freeze * chore: add parameter to control pk_index replacement * fix: dedup pk weights also * fix: generate pk array before dedup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Impl
DataBuffer::freezemethod, which sorts rows inDataBufferaccording to pk weights and replaces pk_index values with pk_weights directly.Checklist
Refer to a related PR or issue link (optional)