Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement write and fork for the new memtable #3357

Merged
merged 14 commits into from Feb 23, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Feb 22, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR implements write() for the merge tree memtable and adds tests for it.

  • write_with_key() and test for the ShardBuilder
  • write_with_pk_id() and test for the Shard
  • write_with_key() for the Partition.

It also implements most methods for the Partition, Shard, and ShardBuilder except those related to scanning the tree.

  • freeze()
  • is_empty()
  • fork()

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 22, 2024
@evenyag evenyag marked this pull request as ready for review February 22, 2024 07:38
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 79.22912% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 85.14%. Comparing base (90e9b69) to head (ffa5354).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3357      +/-   ##
==========================================
- Coverage   85.39%   85.14%   -0.26%     
==========================================
  Files         892      892              
  Lines      146042   146412     +370     
==========================================
- Hits       124712   124661      -51     
- Misses      21330    21751     +421     

@evenyag evenyag changed the title feat: Implement write for the merge tree memtable feat: Implement write and fork for the new memtable Feb 22, 2024
@fengjiachun
Copy link
Collaborator

@evenyag There are some conflicts

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Feb 23, 2024
Merged via the queue into GreptimeTeam:main with commit b144836 Feb 23, 2024
16 checks passed
@v0y4g3r v0y4g3r deleted the feat/read-shard branch February 23, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants