Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: treat "0" and "1" as valid boolean values. #3370

Merged
merged 3 commits into from Feb 23, 2024
Merged

fix: treat "0" and "1" as valid boolean values. #3370

merged 3 commits into from Feb 23, 2024

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

fix #3368

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 23, 2024
tisonkun
tisonkun reviewed Feb 23, 2024
View reviewed changes
src/sql/src/statements.rs Outdated Show resolved Hide resolved
tisonkun
tisonkun approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK we're specially handling this MySQL JDBC manner.

Comments inline for records.

@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (b144836) to head (288c923).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3370      +/-   ##
==========================================
- Coverage   85.56%   85.19%   -0.38%     
==========================================
  Files         892      892              
  Lines      146412   146416       +4     
==========================================
- Hits       125282   124738     -544     
- Misses      21130    21678     +548

MichaelScofield and others added 2 commits February 23, 2024 19:29
@MichaelScofield @tisonkun
Update src/sql/src/statements.rs
cec970d 
Co-authored-by: tison <wander4096@gmail.com>
@MichaelScofield
Fix tests.
288c923
@tisonkun tisonkun added this pull request to the merge queue Feb 23, 2024
Merged via the queue into GreptimeTeam:main with commit a6564e7 Feb 23, 2024
16 checks passed
@MichaelScofield MichaelScofield deleted the 3368-failed-to-parse-0-and-1-as-boolean-at-insertion branch February 26, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@WenyXu WenyXu WenyXu approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to parse 0 and 1 as boolean at insertion
3 participants
@MichaelScofield @tisonkun @WenyXu