Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement iter for the new memtable #3373

Merged
merged 15 commits into from Feb 25, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Feb 24, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR mainly implements the iter() method for the new memtable.

  • The iter() method returns a TreeIter to iterate partitions
  • The memtable can use filters to prune partitions
  • The TreeIter read partitions one by one
  • For each partition, the iter creates a PartitionReader
  • The PartitionReader merges DataBatches from different ShardReaderImpls and the ShardBuilderReaders
  • Each ShardReader merges DataBatches from different data parts.

Unresolved problem:

  • Integrates with the DedupReader

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 24, 2024
@evenyag evenyag marked this pull request as ready for review February 25, 2024 06:26
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 76.24190% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 85.21%. Comparing base (afe4633) to head (3337cfa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3373      +/-   ##
==========================================
- Coverage   85.60%   85.21%   -0.40%     
==========================================
  Files         893      893              
  Lines      146815   147210     +395     
==========================================
- Hits       125676   125438     -238     
- Misses      21139    21772     +633     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Feb 25, 2024
Merged via the queue into GreptimeTeam:main with commit 8059b95 Feb 25, 2024
17 checks passed
@evenyag evenyag deleted the feat/read-partition branch February 25, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants