Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused imports in memtable_util.rs #3376

Merged
merged 1 commit into from Feb 25, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Feb 25, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

remove unused imports in memtable_util.rs. Clippy does not deny these unused imports as we explicitly allow this.

#[cfg_attr(feature = "test", allow(unused))]

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 25, 2024
@v0y4g3r v0y4g3r marked this pull request as ready for review February 25, 2024 09:12
@v0y4g3r v0y4g3r requested a review from evenyag February 25, 2024 09:12
@waynexia waynexia added this pull request to the merge queue Feb 25, 2024
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.21%. Comparing base (8059b95) to head (d574a63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3376      +/-   ##
==========================================
- Coverage   85.61%   85.21%   -0.41%     
==========================================
  Files         893      893              
  Lines      147210   147210              
==========================================
- Hits       126039   125438     -601     
- Misses      21171    21772     +601     

Merged via the queue into GreptimeTeam:main with commit 606309f Feb 25, 2024
28 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants