Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement dedup for the new memtable and expose the config #3377

Merged
merged 6 commits into from Feb 25, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Feb 25, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR implements dedup for the new memtable. It adds a config to the MitoConfig to enable the new table.

This PR contains some bug fixes while testing the new memtable.

  • It fixes an issue that the PartitionReader doesn't prune the first entry its underlying source returns.
  • It also fixes that the KeyValue returns incorrect field num.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 25, 2024
@evenyag evenyag changed the title feat: Add the new memtable to experimental features feat: Implement dedup for the new memtable Feb 25, 2024
@evenyag evenyag changed the title feat: Implement dedup for the new memtable feat: Implement dedup for the new memtable and expose the memtable config Feb 25, 2024
@evenyag evenyag changed the title feat: Implement dedup for the new memtable and expose the memtable config feat: Implement dedup for the new memtable and expose the config Feb 25, 2024
@evenyag evenyag marked this pull request as ready for review February 25, 2024 10:23
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 93.47826% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 85.26%. Comparing base (606309f) to head (39bc725).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3377      +/-   ##
==========================================
- Coverage   85.65%   85.26%   -0.40%     
==========================================
  Files         893      893              
  Lines      147210   147247      +37     
==========================================
- Hits       126099   125543     -556     
- Misses      21111    21704     +593     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Feb 25, 2024
Merged via the queue into GreptimeTeam:main with commit e481f07 Feb 25, 2024
16 checks passed
@v0y4g3r v0y4g3r deleted the feat/dedup-read branch February 25, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants