Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana): enable shared tooltip, add raft engine throughput #3387

Merged
merged 1 commit into from Feb 26, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Feb 26, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This patch contains two changes to grafana dashboard config:

enable shared tooltip. Now the hover dashed line will show up in every panel

image

add throughput to the WAL panel. Request size cannot reflect the real workload.

image

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3262

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 26, 2024
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grafana/greptimedb.json Show resolved Hide resolved
@waynexia waynexia changed the title feat: enable shared tooltip, add raft engine throughput feat(grafana): enable shared tooltip, add raft engine throughput Feb 26, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@waynexia waynexia added this pull request to the merge queue Feb 26, 2024
Merged via the queue into GreptimeTeam:main with commit d8dc93f Feb 26, 2024
18 checks passed
@waynexia waynexia deleted the grafana-config-2 branch February 26, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants