Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: range fix in modulo function tests #3389

Merged
merged 1 commit into from Feb 26, 2024

Conversation

dimbtp
Copy link
Contributor

@dimbtp dimbtp commented Feb 26, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

In tests for modulo function, the check range should be 0..4 rather than 0..3.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3147

@github-actions github-actions bot added the Doc not needed This PR do not impact docs label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (d8dc93f) to head (9c52b94).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3389      +/-   ##
==========================================
- Coverage   85.67%   85.31%   -0.37%     
==========================================
  Files         893      893              
  Lines      147382   147382              
==========================================
- Hits       126270   125734     -536     
- Misses      21112    21648     +536     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Feb 26, 2024
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be able to cover with some unit tests? @dimbtp

Merged via the queue into GreptimeTeam:main with commit b1e290f Feb 26, 2024
16 checks passed
@tisonkun
Copy link
Contributor

Well the chanegs itself is about test. Perhaps we should use test: ... cause fix: ... means a user-aware bugfixies.

@tisonkun tisonkun changed the title fix: range fix in modulo function tests test: range fix in modulo function tests Feb 26, 2024
@dimbtp dimbtp deleted the fix/modulo-test branch February 27, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc not needed This PR do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants