Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration for tls watch option #3395

Merged
merged 4 commits into from Mar 1, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Feb 27, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This patch adds configuration item watch to TlsOption to control notify behaviour.

part 2 of #3335 , Fixes #3255

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.54%. Comparing base (b1e290f) to head (14e839a).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3395      +/-   ##
==========================================
- Coverage   85.68%   84.54%   -1.14%     
==========================================
  Files         893      899       +6     
  Lines      147382   148982    +1600     
==========================================
- Hits       126285   125959     -326     
- Misses      21097    23023    +1926     

@sunng87
Copy link
Member Author

sunng87 commented Feb 28, 2024

Ignore the coverage error because this patch is mainly for test and doesn't introduce anything big. It might be a coverage error I think.

@tisonkun
Copy link
Contributor

Ignore the coverage error because this patch is mainly for test and doesn't introduce anything big. It might be a coverage error I think.

Exactly why I don't like Codecov 🤣

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment on naming.

src/servers/src/tls.rs Outdated Show resolved Hide resolved
@tisonkun tisonkun added this pull request to the merge queue Mar 1, 2024
Merged via the queue into GreptimeTeam:main with commit d4a54a0 Mar 1, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reloadable certificates and keys support
3 participants