Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flow): accumlator for aggr func #3396

Merged
merged 14 commits into from
Mar 12, 2024
Merged

feat(flow): accumlator for aggr func #3396

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1e96a50
feat: Accumlator trait
discord9 Feb 6, 2024
4d1944f
feat: add `OrdValue` accum&use enum_dispatch
discord9 Feb 6, 2024
7a1c7be
test: more accum test
discord9 Feb 7, 2024
d1925dd
feat: eval aggr funcs
discord9 Feb 7, 2024
879131c
chore: refactor test&fmt clippy
discord9 Feb 27, 2024
be642e5
refactor: less verbose
discord9 Feb 27, 2024
c925011
test: more tests
discord9 Feb 28, 2024
bde3522
refactor: better err handling&use OrdValue for Count
discord9 Feb 28, 2024
f0f9144
refactor: ignore null&more tests for error handle
discord9 Feb 28, 2024
e4d785d
refactor: OrdValue accum
discord9 Mar 11, 2024
62177f2
chore: extract null check
discord9 Mar 11, 2024
f7728f8
refactor: def&use fn signature
discord9 Mar 11, 2024
2efbdda
chore: use extra cond with match guard
discord9 Mar 11, 2024
1fe914e
chore: per review
discord9 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/flow/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ common-query.workspace = true
common-telemetry.workspace = true
common-time.workspace = true
datatypes.workspace = true
enum_dispatch = "0.3"
hydroflow = "0.5.0"
itertools.workspace = true
num-traits = "0.2"
Expand All @@ -27,3 +28,6 @@ session.workspace = true
snafu.workspace = true
tokio.workspace = true
tonic.workspace = true

[dev-dependencies]
serde_json = "1.0"
3 changes: 3 additions & 0 deletions src/flow/src/expr/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,7 @@ pub enum EvalError {

#[snafu(display("Unsupported temporal filter: {reason}"))]
UnsupportedTemporalFilter { reason: String, location: Location },

#[snafu(display("Overflowed during evaluation"))]
Overflow { location: Location },
}