feat: zero copy on split rows #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
force-pushed
the
feat/zero-copy-split-rows
branch
from
d06abf5
to
e24e693
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3407 +/- ##
==========================================
- Coverage 85.06% 84.61% -0.45%
==========================================
Files 889 889
Lines 146280 146291 +11
==========================================
- Hits 124428 123790 -638
- Misses 21852 22501 +649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
If a table has multiple regions, then when writing, it is necessary to split the data according to regions, which will incur memory copy overhead.
There is a scenario where the writes of the same client instance usually only contain data from one region (depending on the partition key). In this case, we should avoid memory copying.
Checklist
Refer to a related PR or issue link (optional)