New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement multi-dim partition rule #3409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Invalid PR Title
docs-not-required
This change does not impact docs.
labels
Feb 28, 2024
waynexia
changed the title
Expr partition rule
feat: implement multi-dim partition rule
Feb 28, 2024
WenyXu
reviewed
Mar 4, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: WenyXu <wenymedia@gmail.com>
WenyXu
force-pushed
the
expr-partition-rule
branch
from
March 5, 2024 07:17
9f5eb8c
to
4876e6f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3409 +/- ##
==========================================
- Coverage 85.09% 85.05% -0.04%
==========================================
Files 889 895 +6
Lines 146519 147091 +572
==========================================
+ Hits 124677 125112 +435
- Misses 21842 21979 +137 |
WenyXu
force-pushed
the
expr-partition-rule
branch
from
March 5, 2024 07:37
4876e6f
to
17b9c77
Compare
Signed-off-by: WenyXu <wenymedia@gmail.com>
WenyXu
force-pushed
the
expr-partition-rule
branch
2 times, most recently
from
March 5, 2024 08:04
4e78884
to
031a9ff
Compare
WenyXu
force-pushed
the
expr-partition-rule
branch
from
March 5, 2024 08:41
031a9ff
to
1c45d5d
Compare
killme2008
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM. Don't forget to add the docs for
// TODO(ruihang): docs |
MichaelScofield
approved these changes
Mar 5, 2024
WenyXu
approved these changes
Mar 5, 2024
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
A rough implement of the new partition rule
Note:
This PR is not fully ready to merge. I'll add unit test and error handling later
Checklist
Refer to a related PR or issue link (optional)
#3351