Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement multi-dim partition rule #3409

Merged
merged 10 commits into from Mar 5, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Feb 28, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

A rough implement of the new partition rule

Note:
This PR is not fully ready to merge. I'll add unit test and error handling later

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3351

@github-actions github-actions bot added Invalid PR Title docs-not-required This change does not impact docs. labels Feb 28, 2024
@waynexia waynexia changed the title Expr partition rule feat: implement multi-dim partition rule Feb 28, 2024
@evenyag evenyag mentioned this pull request Mar 5, 2024
8 tasks
waynexia and others added 4 commits March 5, 2024 07:07
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: WenyXu <wenymedia@gmail.com>
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 78.30508% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 85.05%. Comparing base (4915786) to head (aa6aaa5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3409      +/-   ##
==========================================
- Coverage   85.09%   85.05%   -0.04%     
==========================================
  Files         889      895       +6     
  Lines      146519   147091     +572     
==========================================
+ Hits       124677   125112     +435     
- Misses      21842    21979     +137     

@WenyXu WenyXu force-pushed the expr-partition-rule branch 2 times, most recently from 4e78884 to 031a9ff Compare March 5, 2024 08:04
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM. Don't forget to add the docs for

// TODO(ruihang): docs

src/operator/src/statement/ddl.rs Outdated Show resolved Hide resolved
src/operator/src/tests/partition_manager.rs Show resolved Hide resolved
src/partition/src/expr.rs Show resolved Hide resolved
src/partition/src/manager.rs Show resolved Hide resolved
src/partition/src/multi_dim.rs Show resolved Hide resolved
src/partition/src/multi_dim.rs Show resolved Hide resolved
tests-fuzz/src/translator/mysql/create_expr.rs Outdated Show resolved Hide resolved
src/operator/src/statement/ddl.rs Show resolved Hide resolved
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@killme2008 killme2008 added this pull request to the merge queue Mar 5, 2024
Merged via the queue into GreptimeTeam:main with commit 0206350 Mar 5, 2024
17 checks passed
@waynexia waynexia deleted the expr-partition-rule branch March 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants