Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: employ sparse key encoding for shard lookup #3410

Merged
merged 5 commits into from Mar 1, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Feb 28, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR employs spase key encoding to encode primary keys to bytes for primary key to pk id look up.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 28, 2024
@v0y4g3r v0y4g3r requested a review from evenyag February 28, 2024 16:13
@v0y4g3r v0y4g3r marked this pull request as ready for review February 29, 2024 12:10
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 72.52747% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 84.61%. Comparing base (3413fc0) to head (4a28cad).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3410      +/-   ##
==========================================
- Coverage   85.06%   84.61%   -0.45%     
==========================================
  Files         889      889              
  Lines      146280   146398     +118     
==========================================
- Hits       124428   123871     -557     
- Misses      21852    22527     +675     

@v0y4g3r v0y4g3r changed the title feat: employ short key encoding for shard lookup feat: employ sparse key encoding for shard lookup Feb 29, 2024
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

src/mito2/src/memtable/merge_tree/tree.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r force-pushed the feat/merge-tree-key-encoding branch from 7d4def7 to 4a28cad Compare March 1, 2024 03:51
@evenyag evenyag added this pull request to the merge queue Mar 1, 2024
Merged via the queue into GreptimeTeam:main with commit 376409b Mar 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants