New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: employ sparse key encoding for shard lookup #3410
feat: employ sparse key encoding for shard lookup #3410
Conversation
cbc1fcc
to
8e51ca2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3410 +/- ##
==========================================
- Coverage 85.06% 84.61% -0.45%
==========================================
Files 889 889
Lines 146280 146398 +118
==========================================
- Hits 124428 123871 -557
- Misses 21852 22527 +675 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7d4def7
to
4a28cad
Compare
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR employs spase key encoding to encode primary keys to bytes for primary key to pk id look up.
Checklist
Refer to a related PR or issue link (optional)