Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: partition region id #3414

Merged
merged 1 commit into from Feb 29, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

The region routes belong to the physical table but are shared among all logical tables.
That it to say, the region id points to the physical table, so we need to use the actual table id (which may be a logical table) to renew the region id when we want construct the PartitionInfo.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (a500252) to head (a1161d8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3414      +/-   ##
==========================================
- Coverage   85.02%   84.62%   -0.40%     
==========================================
  Files         889      889              
  Lines      146332   146333       +1     
==========================================
- Hits       124421   123837     -584     
- Misses      21911    22496     +585     

@waynexia waynexia added this pull request to the merge queue Feb 29, 2024
Merged via the queue into GreptimeTeam:main with commit 3cad9d9 Feb 29, 2024
16 checks passed
@fengjiachun fengjiachun deleted the fix/invalid-partion-id branch February 29, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants