Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Correct server metrics and add more metrics for scan #3426

Merged
merged 12 commits into from
Mar 4, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Mar 4, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR improves existing metrics and adds more metrics for scan

  • Adds an attach_timer() method and an OnDone stream adapter to observe the duration to fetch a stream, this fixes
    • GRPC_HANDLE_PROMQL_ELAPSED
    • GRPC_HANDLE_SQL_ELAPSED
    • EXEC_PLAN_ELAPSED
  • Removes the METRIC_ prefix from metrics in query mod
  • Move track_metrics to metrics mod and rename it
  • Removes some metrics under servers mod as we already collect it in the HTTP middleware
  • Combine query metrics into a histogram vec
  • Register the gRPC metrics middleware
  • Add more metrics to track scan cost

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 4, 2024
@evenyag evenyag marked this pull request as ready for review March 4, 2024 09:56
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongzc zhongzc added this pull request to the merge queue Mar 4, 2024
Merged via the queue into GreptimeTeam:main with commit 4915786 Mar 4, 2024
21 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants