Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: complete interceptors for all frontend entry #3428

Merged
merged 1 commit into from Mar 5, 2024

Conversation

shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This pr mainly checks and adds interceptors for all frontend protocols we have supported.

discussion: should we use feature gate to cover interceptor logic in OSS build target?

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 5, 2024
Copy link
Member

@sunng87 sunng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any scenario for post_ hooks?

@shuiyisong
Copy link
Contributor Author

We can add post intercept methods anytime when they are needed

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 57.57576% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 84.70%. Comparing base (4915786) to head (172ef8e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3428      +/-   ##
==========================================
- Coverage   85.09%   84.70%   -0.39%     
==========================================
  Files         889      889              
  Lines      146519   146585      +66     
==========================================
- Hits       124677   124165     -512     
- Misses      21842    22420     +578     

@shuiyisong shuiyisong added this pull request to the merge queue Mar 5, 2024
Merged via the queue into GreptimeTeam:main with commit 7b1c350 Mar 5, 2024
16 checks passed
@shuiyisong shuiyisong deleted the fix/complete_interceptor branch March 5, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants