Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for influxdb basic auth #3437

Merged

Conversation

shuiyisong
Copy link
Contributor

@shuiyisong shuiyisong commented Mar 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

This closes #3436

What's changed and what's your intention?

This pr mainly adds support for influxdb basic authorization. See authenticate-with-basic-authentication

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@shuiyisong shuiyisong requested a review from tisonkun March 6, 2024 03:39
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 6, 2024
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun added this to the v0.8 milestone Mar 6, 2024
Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun enabled auto-merge March 6, 2024 03:51
@tisonkun
Copy link
Contributor

tisonkun commented Mar 6, 2024

@shuiyisong FYI this patch seems close #3436, we can use this magic word to close the issue automatically, so that we keep the status synced.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.06%. Comparing base (5d644c0) to head (578cd17).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3437      +/-   ##
==========================================
- Coverage   85.44%   85.06%   -0.39%     
==========================================
  Files         895      895              
  Lines      147091   147093       +2     
==========================================
- Hits       125680   125119     -561     
- Misses      21411    21974     +563     

@tisonkun tisonkun added this pull request to the merge queue Mar 6, 2024
Merged via the queue into GreptimeTeam:main with commit a9d42f7 Mar 6, 2024
20 checks passed
@shuiyisong shuiyisong deleted the fix/support_influxdb_basic_auth branch April 28, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatible with InfluxDB authentication
3 participants