Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl some "set"s to adapt to some client apps #3443

Merged
merged 1 commit into from Mar 6, 2024

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

The "set"s are:

  • ignored:
    • set bytea_output and set datestyle (both have issues tracked) from pg
    • set profiling from mysql. It's not something we will impl (rather we may prefer tracing instead). Plus it's deprecated. See here
  • validated:
    • set client_encoding from pg. Must be "utf8" because it's universal and sufficient, and we don't bother to convert bytes around.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 85.08%. Comparing base (c52bc61) to head (e878854).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3443      +/-   ##
==========================================
- Coverage   85.44%   85.08%   -0.37%     
==========================================
  Files         895      895              
  Lines      147093   147118      +25     
==========================================
- Hits       125685   125170     -515     
- Misses      21408    21948     +540     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun tisonkun added this pull request to the merge queue Mar 6, 2024
Merged via the queue into GreptimeTeam:main with commit 1f1491e Mar 6, 2024
16 checks passed
@MichaelScofield MichaelScofield deleted the feat/impl-some-sets branch March 7, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants