Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify binary name #3449

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 7, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Each fuzz test will add a new binary target. Therefore, we should specify the binary name in Cargo build.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 7, 2024
@tisonkun
Copy link
Contributor

tisonkun commented Mar 7, 2024

Each fuzz test will add a new binary target. Therefore, we should specify the binary name in Cargo build.

I don't get it clearly. Could you elaborate a bit? Is the binary redundant or wrong? Could you attract some logs to explain the case?

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (5d644c0) to head (f20ee83).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
- Coverage   85.44%   85.03%   -0.41%     
==========================================
  Files         895      895              
  Lines      147091   147118      +27     
==========================================
- Hits       125680   125102     -578     
- Misses      21411    22016     +605     

@MichaelScofield MichaelScofield added this pull request to the merge queue Mar 7, 2024
@MichaelScofield
Copy link
Collaborator

@tisonkun I think what @WenyXu trying to achieve here is to reduce some unnecessary bin builds.

Merged via the queue into GreptimeTeam:main with commit 9ec288c Mar 7, 2024
16 checks passed
@tisonkun
Copy link
Contributor

tisonkun commented Mar 7, 2024

Got it. We're reducing unnecessary binary build like fuzz target here ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants