Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate the quote char and value #3455

Merged
merged 1 commit into from Mar 7, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 7, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#3174

What's changed and what's your intention?

Separating the quote char and value allows us to cover more cases easily.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 7, 2024
@WenyXu WenyXu requested a review from fengjiachun March 7, 2024 07:53
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 59.52381% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 85.02%. Comparing base (a218f12) to head (377c143).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3455      +/-   ##
==========================================
- Coverage   85.42%   85.02%   -0.41%     
==========================================
  Files         896      896              
  Lines      147137   147185      +48     
==========================================
- Hits       125696   125139     -557     
- Misses      21441    22046     +605     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Mar 7, 2024
Merged via the queue into GreptimeTeam:main with commit 3f3ef2e Mar 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants